Update documentation on creating release.#8
Open
josephsnyder wants to merge 1 commit intoCastXML:masterfrom
Open
Update documentation on creating release.#8josephsnyder wants to merge 1 commit intoCastXML:masterfrom
josephsnyder wants to merge 1 commit intoCastXML:masterfrom
Conversation
Add information about the steps with CastXMLSuperbuild and the upload to data.kitware.com Add a warning about the "empty-ing" of the Win32 variable when executing the script in this repository.
jcfr
reviewed
Sep 28, 2020
Collaborator
jcfr
left a comment
jcfr
left a comment
There was a problem hiding this comment.
Thanks for working on this 🙏
Before we move forward with integration, here are few nitpicks to address
| Updating tests/test_distribution.py - done | ||
|
|
||
| *Note*: Ensure that the ``Win32_binary`` variables still are set to the | ||
| content of the ``Win64_binary`` variable. It may be set to NULL. |
Collaborator
There was a problem hiding this comment.
Instead, let's fix the script:
CastXML-python-distributions/scripts/update_castxml_version.py
Lines 93 to 94 in 37c6977
In the commit message updating the script, reference issue #5
Suggested change:
- set(win32_binary_url "NA") # Windows 32-bit binaries not available
+ set(win32_binary_url "${win64_binary_url}") # See https://github.com/CastXML/CastXML-python-distributions/issues/5
- set(win32_binary_sha512 "NA")
+ set(win32_binary_sha512 "${win64_binary_sha512}")For some more context, see e03b460#diff-aa166f56653254a5ea3d6db905d61992
|
|
||
| First, build the artifacts which will be made available for download. | ||
|
|
||
| Update CastXML files |
Collaborator
There was a problem hiding this comment.
Let's move this directly into https://github.com/CastXML/CastXMLSuperbuild/blob/master/README.rst adding a section like
Maintainers
-----------
* `How to update CastXML version ? <https://github.com/CastXML/CastXMLSuperbuild/blob/master/docs/make_a_release.rst>`_
* `How to make a release ? <https://github.com/CastXML/CastXMLSuperbuild/blob/master/docs/update_castxml_version.rst>`_
| Upload files to data.kitware.com | ||
| -------------------------------- | ||
|
|
||
| To upload the files generated in the previous step, first create the folder for |
Collaborator
There was a problem hiding this comment.
create the folder ``vX.Y.Z``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add information about the steps with CastXMLSuperbuild and the upload to
data.kitware.com
Add a warning about the "empty-ing" of the Win32 variable when executing
the script in this repository.